[Improve][Formats][Json] Remove assert key word. #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheneyYin
force-pushed
the
format-json-assert
branch
3 times, most recently
from
665471c to
a00ec48
Compare
CheneyYin
changed the title
CheneyYin
commented
Nov 25, 2023
...son/src/main/java/org/apache/seatunnel/format/json/canal/CanalJsonDeserializationSchema.java
Show resolved
Hide resolved
CheneyYin
force-pushed
the
format-json-assert
branch
2 times, most recently
from
370e783 to
60a5f63
Compare
CheneyYin
changed the title
Hisoka-X
reviewed
Nov 27, 2023
...at-json/src/main/java/org/apache/seatunnel/format/json/ogg/OggJsonDeserializationSchema.java
Outdated
Show resolved
Hide resolved
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java
Outdated
Show resolved
Hide resolved
CheneyYin
force-pushed
the
format-json-assert
branch
3 times, most recently
from
23cd1e4 to
82fdbc8
Compare
Hisoka-X
reviewed
Nov 30, 2023
...son/src/main/java/org/apache/seatunnel/format/json/canal/CanalJsonDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...at-json/src/main/java/org/apache/seatunnel/format/json/ogg/OggJsonDeserializationSchema.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...l-format-json/src/test/java/org/apache/seatunnel/format/json/ogg/OggJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...l-format-json/src/test/java/org/apache/seatunnel/format/json/ogg/OggJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...l-format-json/src/test/java/org/apache/seatunnel/format/json/ogg/OggJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...l-format-json/src/test/java/org/apache/seatunnel/format/json/ogg/OggJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
CheneyYin
force-pushed
the
format-json-assert
branch
from
82fdbc8 to
506d12c
Compare
Hisoka-X
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Thanks @CheneyYin for update, I think we reach the last step.
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
...rmat-json/src/test/java/org/apache/seatunnel/format/json/canal/CanalJsonSerDeSchemaTest.java
Outdated
Show resolved
Hide resolved
CheneyYin
force-pushed
the
format-json-assert
branch
from
506d12c to
c2448be
Compare
Hisoka-X
reviewed
Nov 30, 2023
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java
Show resolved
Hide resolved
This was referenced Nov 30, 2023
Closed
|
PTAL @hailin0 |
hailin0
approved these changes
Dec 2, 2023
4 tasks
alextinng
pushed a commit
to alextinng/seatunnel
that referenced
this pull request
Dec 19, 2023
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Remove assert key word.
Related:
assertused to control program flow? #5902Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.