Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix FileUtils::createNewFile not create new file #5943

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Nov 30, 2023

Purpose of this pull request

This PR fix FileUtils::createNewFile not create new file. Just only deleted the old one file.

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test

Check list

@Hisoka-X Hisoka-X added the bug label Nov 30, 2023
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 354fc4b into apache:dev Dec 12, 2023
4 checks passed
@Hisoka-X Hisoka-X deleted the fix-create-new-file branch December 12, 2023 07:33
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants