-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][CDC Base] Fix added columns cannot be parsed after job restore #6118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please rebase dev |
I feel there are still some differences. The existing test cases only test the scenario of adding tables, but not the scenario of adding columns. |
You're right. Tests have been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Purpose of this pull request
Fix added columns cannot be parsed after job restore
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.