[Hotfix][Zeta] Fix job can not restore when last checkpoint failed #6193

EricJoy2048 · 2024-01-12T06:51:18Z

Purpose of this pull request

If the last checkpoint failed, the job will can not be restore.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to connector-v2
2. Update plugin-mapping.properties and add new connector information in it
3. Update the pom file of seatunnel-dist
Update the release-note.

EricJoy2048 · 2024-01-12T06:52:27Z

@Hisoka-X PTAL.

...erver/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java

Hisoka-X

shall we add some test case？

…/seatunnel into 240112_fix_zeta_scheduler

...erver/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java

.../seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/log4j2-test.properties

…pache#6193)

Fix job can not restore when last checkpoint failed

8272803

EricJoy2048 added this to the 2.3.4 milestone Jan 12, 2024

TaoZex reviewed Jan 12, 2024

View reviewed changes

...erver/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java Outdated Show resolved Hide resolved

Hisoka-X reviewed Jan 13, 2024

View reviewed changes

EricJoy2048 added 7 commits January 13, 2024 12:47

add test case

23468f5

Add test case

48641b5

Add test case

0fe913f

Add test case

c1b6ae0

close the zeta engine client is ci

2b0a6ae

Merge branch '240112_fix_zeta_scheduler' of https://github.com/apache…

f28f345

…/seatunnel into 240112_fix_zeta_scheduler

format code

da5dfe7

Hisoka-X reviewed Jan 17, 2024

View reviewed changes

...erver/src/main/java/org/apache/seatunnel/engine/server/checkpoint/CheckpointCoordinator.java Outdated Show resolved Hide resolved

remove test case

472fab4

Hisoka-X reviewed Jan 17, 2024

View reviewed changes

.../seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/log4j2-test.properties Outdated Show resolved Hide resolved

remove test code

cc135ab

Hisoka-X approved these changes Jan 17, 2024

View reviewed changes

github-actions bot added approved reviewed labels Jan 17, 2024

hailin0 approved these changes Jan 17, 2024

View reviewed changes

EricJoy2048 merged commit 59f60b9 into dev Jan 17, 2024
59 of 60 checks passed

EricJoy2048 deleted the 240112_fix_zeta_scheduler branch January 17, 2024 12:34

hailin0 mentioned this pull request Jun 18, 2024

SeaTunnel community meeting Topic collect #7004

Closed

3 tasks

chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024

[Hotfix][Zeta] Fix job can not restore when last checkpoint failed (a…

3e8c69e

…pache#6193)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hotfix][Zeta] Fix job can not restore when last checkpoint failed #6193

[Hotfix][Zeta] Fix job can not restore when last checkpoint failed #6193

EricJoy2048 commented Jan 12, 2024

EricJoy2048 commented Jan 12, 2024

Hisoka-X left a comment

[Hotfix][Zeta] Fix job can not restore when last checkpoint failed #6193

[Hotfix][Zeta] Fix job can not restore when last checkpoint failed #6193

Conversation

EricJoy2048 commented Jan 12, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

EricJoy2048 commented Jan 12, 2024

Hisoka-X left a comment

Choose a reason for hiding this comment