Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Rest-API] Submit or stop job from an inactive master node #6217

Merged
merged 18 commits into from
Jan 17, 2024
Merged

[Fix][Rest-API] Submit or stop job from an inactive master node #6217

merged 18 commits into from
Jan 17, 2024

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Jan 15, 2024

Purpose of this pull request

close #6208

Does this PR introduce any user-facing change?

No

How was this patch tested?

test case

Check list

Hisoka-X
Hisoka-X reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case

@VincentSleepless
Copy link

good job ~~

gdliu3 added 2 commits January 17, 2024 12:13
1
6c9df44
Merge branch 'bugfix-44' of https://github.com/liugddx/incubator-seat…
820dad7 
…unnel into bugfix-44

# Conflicts:
#	seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/resources/hazelcast.yaml
@liugddx liugddx requested a review from Hisoka-X January 17, 2024 05:36
gdliu3 added 2 commits January 17, 2024 17:40
Hisoka-X
Hisoka-X previously approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed.

@liugddx
Merge remote-tracking branch 'upstream/dev' into bugfix-44
2b89371 
# Conflicts:
#	seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/RestApiIT.java
@liugddx
1
42c6a73
@github-actions github-actions bot removed the approved label Jan 17, 2024
@github-actions github-actions bot removed the reviewed label Jan 17, 2024
@liugddx liugddx requested a review from Hisoka-X January 17, 2024 13:00
@Hisoka-X Hisoka-X changed the title [bugfix][rest api]Submit or Stop job from an inactive master node [Fix][Rest-API] Submit or stop job from an inactive master node Jan 17, 2024
@hailin0 hailin0 merged commit a09d3bb into apache:dev Jan 17, 2024
5 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@liugddx
[Fix][Rest-API] Submit or stop job from an inactive master node (apac…
7e94a35 
…he#6217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Zeta RestApi ] Submit or Stop job from an inactive master node
4 participants
@liugddx @VincentSleepless @hailin0 @Hisoka-X