Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][RestAPI] always return jobId when call getJobInfoById API #6422

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[Improve][RestAPI] always return jobId when call getJobInfoById API #6422

merged 2 commits into from
Mar 6, 2024

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

improve the rest api. when get job status by job id. always return the job id to response.

Does this PR introduce any user-facing change?

How was this patch tested?

no need

Check list

@liunaijie liunaijie force-pushed the restapi-getrunningjob branch from f13d2c3 to 0729bbf Compare February 29, 2024 06:52
@liunaijie
Copy link
Member Author

@liugddx PTAL

EricJoy2048
EricJoy2048 previously approved these changes Mar 4, 2024
View reviewed changes
liugddx
liugddx reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a UT case.

@liunaijie liunaijie force-pushed the restapi-getrunningjob branch from 2633ed6 to 81c2f33 Compare March 6, 2024 03:54
@liunaijie liunaijie force-pushed the restapi-getrunningjob branch from 81c2f33 to 771ebcf Compare March 6, 2024 05:03
@liunaijie
Copy link
Member Author

Please add a UT case.

Done, PTAL, thx

liugddx
liugddx approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hailin0 hailin0 merged commit 78cb0de into apache:dev Mar 6, 2024
6 checks passed
@liunaijie liunaijie deleted the restapi-getrunningjob branch March 8, 2024 03:42
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@liunaijie
[Improve][RestAPI] always return jobId when call getJobInfoById API (a…
4fb1225 
…pache#6422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@liugddx liugddx liugddx approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 left review comments

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liunaijie @hailin0 @EricJoy2048 @liugddx