Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Test] Add test case for zeta local mode #6536

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

add test case #6521

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@liunaijie liunaijie force-pushed the add-e2e-for-local-mode branch from d9bf43e to eefe4cb Compare March 19, 2024 08:42
@liunaijie
Copy link
Member Author

@Hisoka-X PTAL

clientConfig
.getConnectionStrategyConfig()
.getConnectionRetryConfig()
.setClusterConnectTimeoutMillis(3000);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hazelcast-client config in this e2e is not same with config/hazelcast-client config. missing this parameter, so add manully.

@Hisoka-X Hisoka-X changed the title [Improve] add test case [Improve][Test] Add test case for zeta local mode Mar 20, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 merged commit 216efb7 into apache:dev Mar 20, 2024
5 checks passed
@liunaijie liunaijie deleted the add-e2e-for-local-mode branch March 20, 2024 08:21
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants