Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][Jdbc/CDC] Fix postgresql uuid type in jdbc read #6684

Merged
merged 1 commit into from
May 9, 2024
Merged

[Hotfix][Jdbc/CDC] Fix postgresql uuid type in jdbc read #6684

merged 1 commit into from
May 9, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Apr 10, 2024

Purpose of this pull request

[Jdbc/CDC] Fix postgresql uuid type in jdbc read

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added

Check list

@hailin0 hailin0 marked this pull request as ready for review April 11, 2024 02:09
Hisoka-X
Hisoka-X reviewed Apr 11, 2024
View reviewed changes
...c/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java
@@ -405,4 +409,8 @@ default JdbcConnectionProvider getJdbcConnectionProvider(
JdbcConnectionConfig jdbcConnectionConfig) {
return new SimpleJdbcConnectionProvider(jdbcConnectionConfig);
}

default String convertType(String columnName, String columnType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comment for this method? I can not get how to use it.

Copy link
Member Author

@hailin0 hailin0 Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added docs

@hailin0 hailin0 force-pushed the dev-fix-pg-uuid-type branch from 3e84437 to 40e598e Compare April 16, 2024 06:39
TaoZex
TaoZex approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Hisoka-X
Hisoka-X approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0 hailin0 added this to the 2.3.6 milestone May 9, 2024
Carl-Zhou-CN
Carl-Zhou-CN approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Carl-Zhou-CN Carl-Zhou-CN merged commit 868ba4d into apache:dev May 9, 2024
6 checks passed
liunaijie pushed a commit to liunaijie/seatunnel that referenced this pull request Aug 1, 2024
@hailin0 @liunaijie
[Hotfix][Jdbc/CDC] Fix postgresql uuid type in jdbc read (apache#6684)
d022fd6
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
@hailin0
[Hotfix][Jdbc/CDC] Fix postgresql uuid type in jdbc read (apache#6684)
ef22458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@TaoZex TaoZex TaoZex approved these changes

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

Assignees
No one assigned
Labels
approved bugfix jdbc postgresql reviewed
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.
4 participants
@hailin0 @Hisoka-X @TaoZex @Carl-Zhou-CN