Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Transform] Remove can't find field exception #6691

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[Improve][Transform] Remove can't find field exception #6691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec336b
Remove can't find field exception
xiaochen-zhou Apr 11, 2024
344f17c
remove duplicate exception
xiaochen-zhou Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 19 additions & 31 deletions ...ansforms-v2/src/main/java/org/apache/seatunnel/transform/filter/FilterFieldTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,32 +35,23 @@
import lombok.extern.slf4j.Slf4j;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;

@Slf4j
public class FilterFieldTransform extends AbstractCatalogSupportTransform {
public static final String PLUGIN_NAME = "Filter";
private int[] inputValueIndex;
private final String[] fields;
private final List<String> fields;

public FilterFieldTransform(
@NonNull ReadonlyConfig config, @NonNull CatalogTable catalogTable) {
super(catalogTable);
SeaTunnelRowType seaTunnelRowType = catalogTable.getTableSchema().toPhysicalRowDataType();
fields = config.get(FilterFieldTransformConfig.KEY_FIELDS).toArray(new String[0]);
fields = config.get(FilterFieldTransformConfig.KEY_FIELDS);
List<String> canNotFoundFields =
Arrays.stream(fields)
.filter(
field -> {
try {
seaTunnelRowType.indexOf(field);
return false;
} catch (Exception e) {
return true;
}
})
fields.stream()
.filter(field -> seaTunnelRowType.indexOf(field, false) == -1)
.collect(Collectors.toList());

if (!CollectionUtils.isEmpty(canNotFoundFields)) {
Expand All @@ -77,34 +68,32 @@ public String getPluginName() {
@Override
protected SeaTunnelRow transformRow(SeaTunnelRow inputRow) {
// todo reuse array container if not remove fields
Object[] values = new Object[fields.length];
for (int i = 0; i < fields.length; i++) {
Object[] values = new Object[fields.size()];
for (int i = 0; i < fields.size(); i++) {
values[i] = inputRow.getField(inputValueIndex[i]);
}
return new SeaTunnelRow(values);
SeaTunnelRow outputRow = new SeaTunnelRow(values);
outputRow.setRowKind(inputRow.getRowKind());
outputRow.setTableId(inputRow.getTableId());
return outputRow;
}

@Override
protected TableSchema transformTableSchema() {
List<String> filterFields = Arrays.asList(fields);
List<Column> outputColumns = new ArrayList<>();

SeaTunnelRowType seaTunnelRowType =
inputCatalogTable.getTableSchema().toPhysicalRowDataType();

inputValueIndex = new int[filterFields.size()];
inputValueIndex = new int[fields.size()];
ArrayList<String> outputFieldNames = new ArrayList<>();
for (int i = 0; i < filterFields.size(); i++) {
String field = filterFields.get(i);
List<Column> inputColumns = inputCatalogTable.getTableSchema().getColumns();
for (int i = 0; i < fields.size(); i++) {
String field = fields.get(i);
int inputFieldIndex = seaTunnelRowType.indexOf(field);
if (inputFieldIndex == -1) {
throw TransformCommonError.cannotFindInputFieldError(getPluginName(), field);
}
inputValueIndex[i] = inputFieldIndex;
outputColumns.add(
inputCatalogTable.getTableSchema().getColumns().get(inputFieldIndex).copy());
outputFieldNames.add(
inputCatalogTable.getTableSchema().getColumns().get(inputFieldIndex).getName());
outputColumns.add(inputColumns.get(inputFieldIndex).copy());
outputFieldNames.add(inputColumns.get(inputFieldIndex).getName());
}

List<ConstraintKey> outputConstraintKeys =
Expand All @@ -123,10 +112,9 @@ protected TableSchema transformTableSchema() {
.collect(Collectors.toList());

PrimaryKey copiedPrimaryKey = null;
if (inputCatalogTable.getTableSchema().getPrimaryKey() != null
&& outputFieldNames.containsAll(
inputCatalogTable.getTableSchema().getPrimaryKey().getColumnNames())) {
copiedPrimaryKey = inputCatalogTable.getTableSchema().getPrimaryKey().copy();
PrimaryKey primaryKey = inputCatalogTable.getTableSchema().getPrimaryKey();
if (primaryKey != null && outputFieldNames.containsAll(primaryKey.getColumnNames())) {
copiedPrimaryKey = primaryKey.copy();
}

return TableSchema.builder()
Expand Down
Loading