Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Fix plugin_config #7104

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Jul 4, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@hailin0 hailin0 requested review from EricJoy2048 and Hisoka-X July 4, 2024 05:10
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If we have test case to cover it in ConnectorSpecificationCheckTest would be better.

@EricJoy2048 EricJoy2048 merged commit b78dcaf into apache:dev Jul 4, 2024
4 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 10, 2024
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 13, 2024
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants