Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Connector-V2] Fixed precision problem of decimal data types for paimon sink #7527

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Aug 30, 2024

Purpose of this pull request

Fix the problem that the data type precision of decimal at the sink side is greater than the precision at the source side, the data is written incorrectly. Like this:
The filed in source is decimal(4,1), the value of temp in source is 36.3
截屏2024-08-30 09 52 14
The filed in sinnk is decimal(16,6) which the table is created manually
截屏2024-08-30 09 52 38
And then the result is not correct, the value of temp in sink is 0.000363
截屏2024-08-30 09 50 39

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai changed the title [Hotfix][Connector-V2] Fixed lost data precision for decimal data types [Hotfix][Connector-V2] Fixed lost data precision for decimal data types in paimon sink Aug 30, 2024
@dailai dailai changed the title [Hotfix][Connector-V2] Fixed lost data precision for decimal data types in paimon sink [Hotfix][Connector-V2] Fixed precision problem of decimal data types for paimon sink Aug 30, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dailai

@wuchunfu wuchunfu merged commit df210ea into apache:dev Aug 30, 2024
5 checks passed
@dailai dailai deleted the dev-paimon branch September 3, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants