-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Jdbc DB2 support upsert SQL #7879
Merged
Hisoka-X
merged 1 commit into
apache:dev
from
shashwatsai:ISSUE-4434-db2-upsert-support
Oct 21, 2024
+270
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133 changes: 133 additions & 0 deletions
133
...-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcDb2UpsertIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.seatunnel.connectors.seatunnel.jdbc; | ||
|
|
||
| import org.apache.seatunnel.e2e.common.container.TestContainer; | ||
|
|
||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.TestTemplate; | ||
| import org.testcontainers.containers.Container; | ||
|
|
||
| import com.google.common.collect.Lists; | ||
|
|
||
| import java.io.IOException; | ||
| import java.sql.ResultSet; | ||
| import java.sql.SQLException; | ||
| import java.sql.Statement; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class JdbcDb2UpsertIT extends JdbcDb2IT { | ||
|
|
||
| private static final String CREATE_SQL_SINK = | ||
| "create table %s\n" | ||
| + "(\n" | ||
| + " C_BOOLEAN BOOLEAN,\n" | ||
| + " C_SMALLINT SMALLINT,\n" | ||
| + " C_INT INTEGER NOT NULL PRIMARY KEY,\n" | ||
| + " C_INTEGER INTEGER,\n" | ||
| + " C_BIGINT BIGINT,\n" | ||
| + " C_DECIMAL DECIMAL(5),\n" | ||
| + " C_DEC DECIMAL(5),\n" | ||
| + " C_NUMERIC DECIMAL(5),\n" | ||
| + " C_NUM DECIMAL(5),\n" | ||
| + " C_REAL REAL,\n" | ||
| + " C_FLOAT DOUBLE,\n" | ||
| + " C_DOUBLE DOUBLE,\n" | ||
| + " C_DOUBLE_PRECISION DOUBLE,\n" | ||
| + " C_CHAR CHARACTER(1),\n" | ||
| + " C_VARCHAR VARCHAR(255),\n" | ||
| + " C_BINARY BINARY(1),\n" | ||
| + " C_VARBINARY VARBINARY(2048),\n" | ||
| + " C_DATE DATE,\n" | ||
| + " C_UPDATED_AT TIMESTAMP DEFAULT CURRENT_TIMESTAMP\n" | ||
| + ");\n"; | ||
|
|
||
| // create a trigger to update the timestamp when the row is updated. | ||
| // if no changes are made to the row, the timestamp should not be updated. | ||
| private static final String CREATE_TRIGGER_SQL = | ||
| "CREATE TRIGGER c_updated_at_trigger\n" | ||
| + " BEFORE UPDATE ON %s\n" | ||
| + " REFERENCING NEW AS new_row\n" | ||
| + " FOR EACH ROW\n" | ||
| + "BEGIN ATOMIC\n" | ||
| + "SET new_row.c_updated_at = CURRENT_TIMESTAMP;\n" | ||
| + "END;"; | ||
|
|
||
| private static final List<String> CONFIG_FILE = | ||
| Lists.newArrayList("/jdbc_db2_source_and_sink_upsert.conf"); | ||
|
|
||
| @Override | ||
| JdbcCase getJdbcCase() { | ||
| jdbcCase = super.getJdbcCase(); | ||
| jdbcCase.setSinkCreateSql(CREATE_SQL_SINK); | ||
| jdbcCase.setConfigFile(CONFIG_FILE); | ||
| jdbcCase.setAdditionalSqlOnSink(CREATE_TRIGGER_SQL); | ||
| return jdbcCase; | ||
| } | ||
|
|
||
| @TestTemplate | ||
| public void testDb2UpsertE2e(TestContainer container) | ||
| throws IOException, InterruptedException, SQLException { | ||
| try { | ||
| // step 1: run the job to migrate data from source to sink. | ||
| Container.ExecResult execResult = | ||
| container.executeJob("/jdbc_db2_source_and_sink_upsert.conf"); | ||
| Assertions.assertEquals(0, execResult.getExitCode(), execResult.getStderr()); | ||
| List<List<Object>> updatedAtTimestampsBeforeUpdate = | ||
| query( | ||
| String.format( | ||
| "SELECT C_UPDATED_AT FROM %s", | ||
| buildTableInfoWithSchema(DB2_DATABASE, DB2_SINK))); | ||
| // step 2: run the job to update the data in the sink. | ||
| // expected: timestamps should not be updated as the data is not changed. | ||
| execResult = container.executeJob("/jdbc_db2_source_and_sink_upsert.conf"); | ||
| Assertions.assertEquals(0, execResult.getExitCode(), execResult.getStderr()); | ||
| List<List<Object>> updatedAtTimestampsAfterUpdate = | ||
| query( | ||
| String.format( | ||
| "SELECT C_UPDATED_AT FROM %s", | ||
| buildTableInfoWithSchema(DB2_DATABASE, DB2_SINK))); | ||
| Assertions.assertIterableEquals( | ||
| updatedAtTimestampsBeforeUpdate, updatedAtTimestampsAfterUpdate); | ||
| } finally { | ||
| clearTable(DB2_DATABASE, DB2_SINK); | ||
| } | ||
| } | ||
|
|
||
| private List<List<Object>> query(String sql) { | ||
| try (Statement statement = connection.createStatement(); | ||
| ResultSet resultSet = statement.executeQuery(sql)) { | ||
| List<List<Object>> result = new ArrayList<>(); | ||
| int columnCount = resultSet.getMetaData().getColumnCount(); | ||
| while (resultSet.next()) { | ||
| ArrayList<Object> objects = new ArrayList<>(); | ||
| for (int i = 1; i <= columnCount; i++) { | ||
| objects.add(resultSet.getString(i)); | ||
| } | ||
| result.add(objects); | ||
| log.debug(String.format("Print query, sql: %s, data: %s", sql, objects)); | ||
| } | ||
| connection.commit(); | ||
| return result; | ||
| } catch (SQLException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
...dbc-e2e/connector-jdbc-e2e-part-1/src/test/resources/jdbc_db2_source_and_sink_upsert.conf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
||
| env { | ||
| parallelism = 1 | ||
| job.mode = "BATCH" | ||
| } | ||
|
|
||
| source { | ||
| # This is a example source plugin **only for test and demonstrate the feature source plugin** | ||
| Jdbc { | ||
| driver = com.ibm.db2.jcc.DB2Driver | ||
| url = "jdbc:db2://db2-e2e:50000/E2E" | ||
| user = "db2inst1" | ||
| password = "123456" | ||
| query = """ | ||
| select * from "E2E".SOURCE; | ||
| """ | ||
| } | ||
|
|
||
| # If you would like to get more information about how to configure seatunnel and see full list of source plugins, | ||
| # please go to https://seatunnel.apache.org/docs/connector-v2/source/Jdbc | ||
| } | ||
|
|
||
| sink { | ||
| Jdbc { | ||
| driver = com.ibm.db2.jcc.DB2Driver | ||
| url = "jdbc:db2://db2-e2e:50000/E2E" | ||
| user = "db2inst1" | ||
| password = "123456" | ||
| database = "E2E" | ||
| table = "SINK" | ||
| enable_upsert = true | ||
| # The primary keys of the table, which will be used to generate the upsert sql | ||
| generate_sink_sql = true | ||
| primary_keys = [ | ||
| C_INT | ||
| ] | ||
| } | ||
|
|
||
| # If you would like to get more information about how to configure seatunnel and see full list of sink plugins, | ||
| # please go to https://seatunnel.apache.org/docs/connector-v2/sink/Jdbc | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please force set
enable_upserttotrueto avoid the test case broken when the default value changed.