-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Core] Rename result_table_name
/source_table_name
to plugin_input/plugin_output
#8072
Conversation
6df5ac4
to
1eb8e16
Compare
result_table_name
/source_table_name
result_table_name
/source_table_name
to plugin_input/plugin_output
1eb8e16
to
9025604
Compare
This is a big change. cc @TyrantLucifer @liugddx @liunaijie @dailai @Carl-Zhou-CN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will this affect existing tasks? |
.stringType() | ||
.noDefaultValue() | ||
.withFallbackKeys("result_table_name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatible with old versions
cc @liugddx
@hailin0 Do we need to keep a few test cases and end-to-end tests for backward compatibility with the old version? |
9025604
to
45f62cc
Compare
...-v2-e2e/connector-fake-e2e/src/test/java/org/apache/seatunnel/e2e/connector/fake/FakeIT.java
Show resolved
Hide resolved
...fake-e2e/src/test/resources/fake_to_assert_with_compatible_source_and_result_table_name.conf
Show resolved
Hide resolved
45f62cc
to
7e31e2a
Compare
7e31e2a
to
22405d4
Compare
PTAL |
This is a big change, even it's backward compatibility with the old version, but how many version should we keep backward, all the time or like 2 or 3 versions? How about add a upgrade note on each release version, in this page, introduce how to upgrade from old version (which is the minimum version). which feature (parameters) is deprecated, moreover we can introduce the features, fixed bug. Now we have the release-node, but it's not enough. WDYT |
I think we should keep it indefinitely, not just for 2 or 3 versions. Perhaps after one or two years, we can revisit it to decide whether to keep or remove it, as keeping it poses no burden to us. However, we should mention in the documentation that the use of result_table_name and source_table_name is no longer recommended. cc @hailin0
+1 |
+1 |
Yes, this is what is still missing |
@Hisoka-X |
We should metion it in doc too, let users to consciously change expired configurations. Doc more important than log. |
Added notes. |
Purpose of this pull request
close #8062
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.