[fix] fix get job metrics get NPE #8093
Conversation
|
part of fix, to avoid get NullPointException. We still need find why the running job can't be find in the IMAP |
liunaijie
force-pushed
the
fix/fix_npe
branch
from
873d44c to
83abdc5
Compare
| @@ -39,4 +39,4 @@ seatunnel: | |||
| metric: | |||
| enabled: false | |||
| logs: | |||
| scheduled-deletion-enable: true | |||
| scheduled-deletion-enable: false | |||
There was a problem hiding this comment.
If this set to true, it will start the log deletion thread to delete log files, first it will lookup the log folder.
But in CI, log4j is using console print, won't write log to file. https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-e2e-common/src/test/resources/log4j2.properties#L25
So when this config enabled, it will get exception
There was a problem hiding this comment.
This problem does exist. Is there any better way to avoid this problem
There was a problem hiding this comment.
Can we disable it in CI? as we won't write log file during CI and there has no test using this config.
There was a problem hiding this comment.
Ok for me. The delete expired log file test case config is
.| coordinatorServiceTest | ||
| .getFlakeIdGenerator(Constant.SEATUNNEL_ID_GENERATOR_NAME) | ||
| .newId(); | ||
| Long jobId = System.currentTimeMillis(); |
| @@ -39,4 +39,4 @@ seatunnel: | |||
| metric: | |||
| enabled: false | |||
| logs: | |||
| scheduled-deletion-enable: true | |||
| scheduled-deletion-enable: false | |||
There was a problem hiding this comment.
Ok for me. The delete expired log file test case config is
.
Purpose of this pull request
part fix of #8081
Does this PR introduce any user-facing change?
no
How was this patch tested?
exist tests
Check list
New License Guide
release-note.