Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] delete chinese desc in code #8306

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

Delete Chinese desc

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X Hisoka-X changed the title [improve][connector-v2][clickhouse] Delete Chinese desc [Improve][Connector-v2][clickhouse] Delete Chinese desc Dec 16, 2024
@Hisoka-X Hisoka-X changed the title [Improve][Connector-v2][clickhouse] Delete Chinese desc [Chore] delete chinese desc in code Dec 16, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 16, 2024

How about add a test case to verify that we can not put chinese into code?

@zhangshenghang
Copy link
Member Author

How about add a test case to verify that we can not put chinese into code?

Good idea, I will do it

@hailin0 hailin0 merged commit a50a8b9 into apache:dev Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants