[SEDONA-237] Add ST_Dimension #867
Conversation
docs/api/sql/Function.md
Outdated
|
|
||
| Format: `ST_Dimension (A:geometry), ST_Dimension (C:geometrycolletion), ` | ||
|
|
||
| Since: `v1.0.0` |
There was a problem hiding this comment.
Please provide docs for Sedona Flink as well.
|
|
||
| Spark SQL example: | ||
| ```sql | ||
| SELECT ST_Dimension('GEOMETRYCOLLECTION(LINESTRING(1 1,0 0),POINT(0 0))'); |
There was a problem hiding this comment.
Please provide the output of the example.
In addition, have you tested other possible types, such as MultiPoint, MultiLineString, MultiPolygon. GeometryCollection can also have nested Multi objects.
We are trying to provide consistent behavior as PostGIS. Please install PostGIS on your end and test the output in PostGIS as well.
| @@ -268,6 +268,38 @@ public void splitHeterogeneousGeometryCollection() { | |||
| assertNull(actualResult); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please separate different testCases to different tests since these are unit tests.
You can have tests like dimensionGeom2D, dimensionGeomCollection, dimensionGeomEmpty, etc.
Also, use assertEquals(expected, actual) format so that the test failure flags expected and actual properly.
Additionally, please add test cases testing 3D geometry as well
| @@ -137,6 +137,20 @@ class functionTestScala extends TestBaseScala with Matchers with GeometrySample | |||
| assert(functionDf.count() > 0); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You can follow the map way of specifying multiple test cases and their expected output here, it is more readable
docs/api/sql/Function.md
Outdated
|
|
||
| Introduction: Return the topological dimension of this Geometry object, which must be less than or equal to the coordinate dimension. OGC SPEC s2.1.1.1 - returns 0 for POINT, 1 for LINESTRING, 2 for POLYGON, and the largest dimension of the components of a GEOMETRYCOLLECTION. If the dimension is unknown (e.g. for an empty GEOMETRYCOLLECTION) 0 is returned. | ||
|
|
||
| Format: `ST_Dimension (A:geometry), ST_Dimension (C:geometrycolletion), ` |
docs/api/flink/Function.md
Outdated
|
|
||
| Introduction: Return the topological dimension of this Geometry object, which must be less than or equal to the coordinate dimension. OGC SPEC s2.1.1.1 - returns 0 for POINT, 1 for LINESTRING, 2 for POLYGON, and the largest dimension of the components of a GEOMETRYCOLLECTION. If the dimension is unknown (e.g. for an empty GEOMETRYCOLLECTION) 0 is returned. | ||
|
|
||
| Format: `ST_Dimension (A:geometry), ST_Dimension (C:geometrycolletion), ` |
|
Additionally, I noticed that your PR description does not have anything in the "How was this PR tested". Please fill that section too. Example PR: #742 |
|
Ah, sorry for the CI problem. It is not clear for the error message. XD. It's OK now. |
Co-authored-by: Jia Yu <jiayu@apache.org>
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Add ST_Dimension function to sedona-common, sedona-sql, sedona-flink, and the dataframe/python API.
How was this patch tested?
Did this PR include necessary documentation updates?