#79 add get interface for polling data #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianxiaoliang
requested changes
Feb 28, 2020
GuoYL123
force-pushed
the
master
branch
5 times, most recently
from
ea9ea57
to
56d5d85
Compare
GuoYL123
force-pushed
the
master
branch
3 times, most recently
from
add44e9
to
75c336a
Compare
GuoYL123
force-pushed
the
master
branch
2 times, most recently
from
cb87c6a
to
fd064a8
Compare
# Conflicts: # pkg/model/kv.go # server/resource/v1/common.go # server/resource/v1/history_resource.go
tianxiaoliang
requested changes
Mar 12, 2020
|
冲突有空解决 |
# Conflicts: # server/resource/v1/kv_resource.go # server/service/mongo/track/polling_detail_dao.go
GuoYL123
force-pushed
the
master
branch
2 times, most recently
from
12d2d97
to
4f4bbb9
Compare
tianxiaoliang
requested changes
Mar 16, 2020
# Conflicts: # pkg/model/kv.go # server/resource/v1/history_resource.go # server/resource/v1/history_resource_test.go
tianxiaoliang
requested changes
Mar 19, 2020
server/handler/track_handler.go
Outdated
| } | ||
| return nil | ||
| resp, _ := ir.Result.(*restful.Response) | ||
| err := cb(ir) |
There was a problem hiding this comment.
不该立刻callback回到前置handler中，应该按顺序执行回去
| return err | ||
| } | ||
| return nil | ||
| resp, _ := ir.Result.(*restful.Response) |
There was a problem hiding this comment.
是否转换成功需要保留，不成功就执行回到前置handler
There was a problem hiding this comment.
没有response header是不是也要记录，如果这样就无法记录
tianxiaoliang
approved these changes
Mar 20, 2020
| WriteErrResponse(context, http.StatusNotFound, err.Error(), common.ContentTypeText) | ||
| return | ||
| } | ||
| WriteErrResponse(context, http.StatusInternalServerError, err.Error(), common.ContentTypeText) |
There was a problem hiding this comment.
先给你合入，我正在做统一的错误处理规范，现在错误返回都太随意了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.