Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mask distSQL parse to AST #384

Merged
merged 6 commits into from
May 31, 2023
Merged

Conversation

wbtlb
Copy link
Contributor

@wbtlb wbtlb commented May 31, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

refrense issue: #270

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the operator solutions of operator label May 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2023

Codecov Report

Merging #384 (d74d2d1) into main (cd25639) will decrease coverage by 1.19%.
The diff coverage is 19.87%.

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   48.52%   47.34%   -1.19%     
==========================================
  Files          46       48       +2     
  Lines        5053     5264     +211     
==========================================
+ Hits         2452     2492      +40     
- Misses       2383     2547     +164     
- Partials      218      225       +7     
Impacted Files Coverage Δ
...perator/pkg/controllers/compute_node_controller.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/proxy_controller.go 0.00% <ø> (ø)
...e-operator/pkg/distsql/visitor/mask_rdl_visitor.go 0.00% <0.00%> (ø)
...rator/pkg/reconcile/storagenode/aws/rdsinstance.go 22.14% <0.00%> (ø)
...operator/pkg/reconcile/computenode/compute_node.go 38.29% <37.63%> (ø)
...perator/pkg/controllers/storage_node_controller.go 55.45% <50.00%> (+0.20%) ⬆️
...perator/pkg/distsql/visitor/encrypt_rdl_visitor.go 48.76% <56.25%> (ø)
...here-operator/pkg/shardingsphere/shardingsphere.go 48.93% <62.50%> (-2.23%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@mlycore mlycore added in: distsql type: enhancement New feature or request labels May 31, 2023
@mlycore mlycore merged commit 86f67ce into apache:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: distsql operator solutions of operator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants