Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements read write splitting distSQL parse to AST #388

Merged
merged 6 commits into from
Jun 3, 2023

Conversation

wbtlb
Copy link
Contributor

@wbtlb wbtlb commented Jun 2, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

refrence issue: #270

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the operator solutions of operator label Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #388 (6449188) into main (e52f093) will decrease coverage by 3.04%.
The diff coverage is 2.80%.

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   47.34%   44.30%   -3.04%     
==========================================
  Files          48       50       +2     
  Lines        5264     5634     +370     
==========================================
+ Hits         2492     2496       +4     
- Misses       2547     2913     +366     
  Partials      225      225              
Impacted Files Coverage Δ
pitr/cli/internal/cmd/backup.go 73.47% <0.00%> (ø)
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <ø> (ø)
...perator/pkg/controllers/compute_node_controller.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/proxy_controller.go 0.00% <ø> (ø)
...operator/pkg/controllers/proxyconfig_controller.go 0.00% <ø> (ø)
...pkg/controllers/shardingsphere_chaos_controller.go 46.46% <ø> (ø)
...sphere-operator/pkg/distsql/visitor/encrypt_rdl.go 48.76% <ø> (ø)
...ingsphere-operator/pkg/distsql/visitor/mask_rdl.go 0.00% <ø> (ø)
...or/pkg/distsql/visitor/read_write_splitting_rdl.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/distsql/visitor/shadow_rdl.go 0.00% <0.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mlycore
mlycore previously approved these changes Jun 2, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mlycore mlycore merged commit c078dec into apache:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: distsql operator solutions of operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants