Fix sonar issue of CalculationContext (#25642)

apache · May 13, 2023 · d8275fe · d8275fe
1 parent 5abb53b
commit d8275fe
Showing 1 changed file with 33 additions and 8 deletions.
diff --git a/...pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java b/...pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java
@@ -20,7 +20,6 @@
 import lombok.Getter;
 import lombok.NonNull;
 import lombok.RequiredArgsConstructor;
-import lombok.Setter;
 import lombok.SneakyThrows;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.lang3.builder.EqualsBuilder;
@@ -55,6 +54,7 @@
 import java.util.Objects;
 import java.util.Optional;
 import java.util.Properties;
+import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Collectors;
 
 /**
@@ -191,21 +191,46 @@ public Collection<String> getSupportedDatabaseTypes() {
     }
 
     @RequiredArgsConstructor
-    @Getter
     private static final class CalculationContext implements AutoCloseable {
 
+        @Getter
         private final Connection connection;
 
-        @Setter
-        private volatile PreparedStatement preparedStatement;
+        private final AtomicReference<PreparedStatement> preparedStatement = new AtomicReference<>();
+
+        private final AtomicReference<ResultSet> resultSet = new AtomicReference<>();
+
+        /**
+         * Get result set.
+         *
+         * @return result set
+         */
+        public ResultSet getResultSet() {
+            return resultSet.get();
+        }
 
-        @Setter
-        private volatile ResultSet resultSet;
+        /**
+         * Set prepared statement.
+         * 
+         * @param preparedStatement prepared statement
+         */
+        public void setPreparedStatement(final PreparedStatement preparedStatement) {
+            this.preparedStatement.set(preparedStatement);
+        }
+
+        /**
+         * Set result set.
+         * 
+         * @param resultSet result set
+         */
+        public void setResultSet(final ResultSet resultSet) {
+            this.resultSet.set(resultSet);
+        }
 
         @Override
         public void close() {
-            CloseUtils.closeQuietly(resultSet);
-            CloseUtils.closeQuietly(preparedStatement);
+            CloseUtils.closeQuietly(resultSet.get());
+            CloseUtils.closeQuietly(preparedStatement.get());
             CloseUtils.closeQuietly(connection);
         }
     }