Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for ComposeClassStaticMethodAroundAdvice and ComposeConstructorAdvice #10958

Closed
2 tasks done
taojintianxia opened this issue Jun 24, 2021 · 8 comments · Fixed by #13958
Closed
2 tasks done

Add unit test for ComposeClassStaticMethodAroundAdvice and ComposeConstructorAdvice #10958

taojintianxia opened this issue Jun 24, 2021 · 8 comments · Fixed by #13958
Assignees
@Swastyy
Labels
feature: agent shardingsphere agent in: test
Milestone
5.1.0

Comments

@taojintianxia
Copy link
Contributor

taojintianxia commented Jun 24, 2021 •
edited by terrymanu
Loading

Hi community,

This issue is for #10887.

Aim

Add unit test for ComposeClassStaticMethodAroundAdvice and ComposeConstructorAdvice to test its public functions.

  • ComposeClassStaticMethodAroundAdvice
  • ComposeConstructorAdvice

Basic Qualifications

  • Java
  • Maven
  • Junit.Test

Example FYI

  • PrivilegeMergeTest
@strongduanmu strongduanmu changed the title Add test case for ComposeClassStaticMethodAroundAdvice and ComposeConstructorAdvice Add unit test for ComposeClassStaticMethodAroundAdvice and ComposeConstructorAdvice Jun 24, 2021
@strongduanmu strongduanmu added this to the 5.0.0-RC1 milestone Jun 24, 2021
@Swastyy
Copy link
Member

Swastyy commented Jul 21, 2021

@taojintianxia I think this is a part of #11156

@tristaZero
Copy link
Contributor

Hi @Swastyy So do you want to take charge of this one?

@Swastyy
Copy link
Member

Swastyy commented Jul 25, 2021

Hi @Swastyy So do you want to take charge of this one?

Yes I am working on it.

@tristaZero
Copy link
Contributor

@Swastyy Hi I am cleaning stale issues, are you still interested in working on it?

@Swastyy
Copy link
Member

Swastyy commented Oct 3, 2021

@Swastyy Hi I am cleaning stale issues, are you still interested in working on it?

Hey @tristaZero I need some time to resolve some errors, if you want to recreate this issue, we can do this.

@tristaZero
Copy link
Contributor

@taojintianxia Hi, we still need to fix this issue, don't we?

@taojintianxia
Copy link
Contributor Author

@taojintianxia Hi, we still need to fix this issue, don't we?

I think so, that should be resolved. @Swastyy if you got any problem , you could paste corresponding info here, in this issue. let's see if we could solve this together

@menghaoranss menghaoranss modified the milestones: 5.0.0-RC1, 5.0.0 Oct 15, 2021
@menghaoranss menghaoranss modified the milestones: 5.0.0, 5.0.1 Oct 31, 2021
@franco-h
Copy link
Contributor

franco-h commented Dec 6, 2021

Hi. Is this issue still available? I tried to resolve this issue and have made a PR. Please review. Thanks

@menghaoranss menghaoranss mentioned this issue Dec 7, 2021
Merged
terrymanu pushed a commit that referenced this issue Dec 20, 2021
@franco-h
Add unit test for ComposeClassStaticMethodAroundAdvice and ComposeCon…
fea1c95 
…structorAdvice (Issue #10958) (#13958)

* Add files via upload

* Rename shardingsphere-agent/shardingsphere-agent-core/src/test/java/org/apache/shardingsphere/agent/core/bytebuddy/transformer/ComposeClassStaticMethodAroundAdviceTest.java to shardingsphere-agent/shardingsphere-agent-core/src/test/java/org/apache/shardingsphere/agent/core/bytebuddy/transformer/advice/ComposeClassStaticMethodAroundAdviceTest.java

* Rename shardingsphere-agent/shardingsphere-agent-core/src/test/java/org/apache/shardingsphere/agent/core/bytebuddy/transformer/ComposeConstructorAdviceTest.java to shardingsphere-agent/shardingsphere-agent-core/src/test/java/org/apache/shardingsphere/agent/core/bytebuddy/transformer/advice/ComposeConstructorAdviceTest.java

* Update ComposeClassStaticMethodAroundAdviceTest.java

* Update ComposeConstructorAdviceTest.java

* Update ComposeClassStaticMethodAroundAdviceTest.java

* Update ComposeConstructorAdviceTest.java
@terrymanu terrymanu added feature: agent shardingsphere agent and removed good first issue labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swastyy Swastyy

Labels
feature: agent shardingsphere agent in: test
Projects
None yet
Milestone
5.1.0
7 participants
@taojintianxia @terrymanu @strongduanmu @tristaZero @menghaoranss @Swastyy @franco-h