Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . #17701

Merged
merged 4 commits into from
May 16, 2022

Conversation

misselvexu
Copy link
Contributor

Fixes #17579 .
Fixes #17580 .

Changes proposed in this pull request:

  • Add test cases for SQLRewriteContextDecoratorFactory .
  • Add test cases for ExecutionPrepareDecoratorFactory .

@codecov-commenter
Copy link

Codecov Report

Merging #17701 (f3c08c7) into master (e52989c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #17701   +/-   ##
=========================================
  Coverage     58.82%   58.82%           
  Complexity     2126     2126           
=========================================
  Files          3599     3599           
  Lines         53570    53570           
  Branches       9146     9146           
=========================================
+ Hits          31510    31513    +3     
+ Misses        19386    19383    -3     
  Partials       2674     2674           
Impacted Files Coverage Δ
.../sql/prepare/ExecutionPrepareDecoratorFactory.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52989c...f3c08c7. Read the comment docs.

@terrymanu terrymanu merged commit 125e5a1 into apache:master May 16, 2022
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 17, 2022
* master: (90 commits)
  Remove usage of com.google.common.collect.Collections2 (apache#17721)
  Refactor execute RAL  statement reload metaData (apache#17720)
  Use caffeine instead of guava cache (apache#17712)
  Minor changes for test cases and code format (apache#17718)
  Add test case for RuleBasedSchemaMetaDataBuilderFactory . (apache#17709)
  Update Mockito and ByteBuddy to help with GraalVM integration (apache#17665)
  fix CI error (apache#17713)
  Add unit for MetaDataPersistService.persistTransactionRule(final Properties props, final boolean isOverwrit)  apache#16091 (apache#17714)
  Remove useless DatabaseMetaDataContextsBuilder (apache#17717)
  private MetaDataContextsBuilder.addDatabase and addSystemDatabases (apache#17716)
  Add unit test for ModShardingAlgorithm  (apache#17710)
  Refactor distribute database lock (apache#17711)
  Add unit test for Bootstrap use proxy default port from props (apache#17707)
  Scaling IT optimization (apache#17702)
  Add test cases for SQLRewriteContextDecoratorFactory and ExecutionPrepareDecoratorFactory . (apache#17701)
  Use ConfigurationProperties in ContextManager (apache#17706)
  Use ConfigurationProperties in MetaDataContextsBuilder (apache#17705)
  Refactor create schema statement parse logic (apache#17703)
  Revise apache#17695 (apache#17700)
  add test for DataNodeBuilderFactory (apache#17695)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case for SQLRewriteContextDecoratorFactory Add test case for ExecutionPrepareDecoratorFactory
3 participants