Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports scaling MySQL table which only contains unique index #17786

Merged
merged 8 commits into from
May 19, 2022

Conversation

TeslaCN
Copy link
Member

@TeslaCN TeslaCN commented May 18, 2022

Relates to #17773.

@TeslaCN TeslaCN changed the title Supports scaling table which only contains unique index Supports scaling MySQL table which only contains unique index May 19, 2022
@TeslaCN TeslaCN marked this pull request as ready for review May 19, 2022 05:06
@TeslaCN TeslaCN added this to the 5.1.2 milestone May 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #17786 (fd6d9dd) into master (6c04dd0) will decrease coverage by 0.02%.
The diff coverage is 28.05%.

❗ Current head fd6d9dd differs from pull request most recent head 66e39b1. Consider uploading reports for the commit 66e39b1 to get more accurate results

@@             Coverage Diff              @@
##             master   #17786      +/-   ##
============================================
- Coverage     59.13%   59.11%   -0.03%     
+ Complexity     2131     2130       -1     
============================================
  Files          3594     3594              
  Lines         53384    53416      +32     
  Branches       9113     9119       +6     
============================================
+ Hits          31571    31577       +6     
- Misses        19142    19169      +27     
+ Partials       2671     2670       -1     
Impacted Files Coverage Δ
...infra/metadata/ShardingSphereDatabaseMetaData.java 5.00% <ø> (-4.53%) ⬇️
...esher/type/AlterIndexStatementSchemaRefresher.java 15.00% <0.00%> (ø)
...sher/type/AlterSchemaStatementSchemaRefresher.java 7.14% <0.00%> (ø)
...esher/type/AlterTableStatementSchemaRefresher.java 8.57% <0.00%> (ø)
...resher/type/AlterViewStatementSchemaRefresher.java 8.33% <0.00%> (ø)
...sher/type/CreateIndexStatementSchemaRefresher.java 23.07% <0.00%> (ø)
...sher/type/CreateTableStatementSchemaRefresher.java 14.28% <0.00%> (ø)
...esher/type/CreateViewStatementSchemaRefresher.java 14.28% <0.00%> (ø)
...resher/type/DropIndexStatementSchemaRefresher.java 13.63% <0.00%> (ø)
...resher/type/DropTableStatementSchemaRefresher.java 15.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0eac34...66e39b1. Read the comment docs.

Copy link
Contributor

@sandynz sandynz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sandynz sandynz merged commit c3e474f into apache:master May 19, 2022
@TeslaCN TeslaCN deleted the enhancement/17773 branch May 19, 2022 05:51
zhaoguhong added a commit to zhaoguhong/shardingsphere that referenced this pull request May 19, 2022
* master:
  Fix the exception when specifying schema when JDBC connects to Proxy (apache#17611)
  Add ProxyContextRestorer to restore proxy context in test cases (apache#17802)
  Remove redundant blank chars and lines in codes (apache#17799)
  Supports scaling MySQL table which only contains unique index (apache#17786)
  Add unit test for ModShardingAlgorithm check Argument(apache#17695) (apache#17772)
  Move getSchemas method to ShardingSphereDatabase (apache#17798)
  Fix unit tests in proxy-frontend-core affected by other tests (apache#17796)
  Update powered by (apache#17795)
  Add support for more JSR-310 related classes about JDBC Timestamp in IntervalShardingAlgorithm (apache#17754)
  Rename ShardingSphereMetaData to ShardingSphereDatabaseMetaData (apache#17792)
  Rename MetaDataContexts.persistService (apache#17789)
  Move ContextManager.executorEngine (apache#17783)
  Change proxy log print at Docker images, get more information (apache#17788)
  fix datasource closed exception for db-discovery (apache#17774)
  Add lock method for schema in lock manager (apache#17787)
  Refactor MetaDataChangedWatcher (apache#17781)
  Refactor PipelineTableMetaDataLoader and fix typo in PipelineTableMetaData (apache#17778)
  Rename DatabaseRulesBuilder (apache#17780)

# Conflicts:
#	shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/test/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaDataTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants