Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split InsertColumnsToken from InsertOptimizeResult #2387

Merged
merged 38 commits into from
May 15, 2019
Merged

Split InsertColumnsToken from InsertOptimizeResult #2387

merged 38 commits into from
May 15, 2019

Conversation

tristaZero
Copy link
Contributor

Fixes #2319.
Ref #2386

tristaZero added 30 commits May 14, 2019 10:49
@tristaZero
rename to BaseSQLRewriteEngine
335e810
@tristaZero
modify java doc for BaseSQLRewriteEngine
e7b1615
@tristaZero
modify java doc for rewrite engine
0311dd3
@tristaZero
reverse to SQLRewriteEngine
a9d1461
@tristaZero
delete setGeneratedKeys()
480f1eb
@tristaZero
Merge branch 'dev' of ssh://github.com/shardingjdbc/sharding-jdbc int…
1fdb52e 
…o dev
@tristaZero
reverse
c66408d
@tristaZero
add ShardingInsertColumnsFiller.java
aaae552
@tristaZero
modify filler rule definition
f3935bb
@tristaZero
add fillWithQueryAssistedColumn
6e016b7
@tristaZero
add createSelectItemsTokenFromSQL()
d6a3b8e
@tristaZero
add createSelectItemsTokenFromMetaData()
fdaae92
@tristaZero
add extractLastIndexOfColumnNames()
13cb3a0
@tristaZero
calculate lastIndexOfColumnNames
d4a8d61
@tristaZero
add SelectItemsToken
c627cf0
@tristaZero
modify createSelectItemsTokenFromMetaData()
17a851d
@tristaZero
add startIndex
640b65b
@tristaZero
add stop index
6c6e80d
@tristaZero
delete lastIndexOfColumnNames
3c6fcf3
@tristaZero
add fillInsertValuesToken()
03971af
@tristaZero
fillInsertValuesToken()
1ed58fb
@tristaZero
modify InsertValuesPlaceholder toString()
f062520
@tristaZero
modify fillInsertValuesToken()
3257242
@tristaZero
add InsertColumnsToken
a98d31f
@tristaZero
use InsertColumnsToken
e862c7f
@tristaZero
add InsertColumnsPlaceholder
c2a70fc
@tristaZero
append InsertColumnsPlaceholder
09eec03
@tristaZero
add getAssistedQueryColumns(logicTableName);
6d0391e
@tristaZero
add reviseInsertColumnsToken()
b37a856
@tristaZero
modify fillQueryAssistedColumn()
6bb8ba5
@tristaZero tristaZero mentioned this pull request May 15, 2019
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8099

  • 24 of 134 (17.91%) changed or added relevant lines in 11 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 60.441%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/ShardingEncryptorEngine.java 0 5 0.0%
sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/ShardingEncryptorStrategy.java 0 6 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/extractor/impl/dml/insert/InsertColumnsExtractor.java 0 6 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/sql/token/impl/InsertColumnsToken.java 0 6 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertValuesFiller.java 0 10 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertColumnsFiller.java 0 16 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertValuesFiller.java 0 21 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertColumnsFiller.java 0 40 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/encrypt/dml/insert/EncryptInsertValuesFiller.java 1 0.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/filler/sharding/dml/insert/ShardingInsertValuesFiller.java 1 0.0%
Totals Coverage Status
Change from base Build 8098: -0.4%
Covered Lines: 8712
Relevant Lines: 14414
💛 - Coveralls

@terrymanu terrymanu merged commit a767df8 into apache:dev May 15, 2019
@terrymanu terrymanu added this to the 4.0.0.M2 milestone May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-RC2
Development

Successfully merging this pull request may close these issues.

Insert error when field name was a keyword
3 participants
@tristaZero @coveralls @terrymanu