-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade antlr4 to 4.10.1 #23937
Upgrade antlr4 to 4.10.1 #23937
Conversation
@TeslaCN @terrymanu can you take a review? |
LGTM |
Hi @zhfeng |
Sorry for the inconvenience. I took these changes because it could build with The for IDEA, I think you have to add source directory manually. such as |
I don't think manually add source directory is acceptable. Because we need to add 15 modules manually to start Proxy or run unit tests in IDEA, and these settings might be lost after doing some operation. I will raise a PR to restore the path of generated codes. |
@TeslaCN can you try this setting? |
Of course I can. But I prefer the way that developers could open the project without addtional settings. |
OK, I just wonder why IDEA could find |
Hmm, it detects |
Fixes #19990.
Changes proposed in this pull request:
antlr4-maven-plugin
in JDK 11Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.