Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the generated key column name case insensitivity error(#32756) #32763

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Fix the generated key column name case insensitivity error(#32756) #32763

merged 7 commits into from
Sep 2, 2024

Conversation

FlyingZC
Copy link
Member

@FlyingZC FlyingZC commented Sep 2, 2024 •
edited
Loading

Fixes #32756.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@FlyingZC FlyingZC self-assigned this Sep 2, 2024
@FlyingZC FlyingZC added this to the 5.5.1 milestone Sep 2, 2024
@FlyingZC FlyingZC changed the title Fix the generated key column name case insensitivity error Fix the generated key column name case insensitivity error(#32756) Sep 2, 2024
strongduanmu
strongduanmu approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@menghaoranss menghaoranss merged commit 484332c into apache:master Sep 2, 2024
141 checks passed
RaigorJiang added a commit that referenced this pull request Oct 22, 2024
@RaigorJiang
Pick #32595, #32763, fix the generated key column name case insensiti…
aa2cf56 
…vity error (#8)

* Pick #32595, #32763, fix the generated key column name case insensitivity error

* Improve DML E2E to support destroy-sql

* Optimize code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees

@FlyingZC FlyingZC

Labels
in: kernel type: bug
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException occurs when execute insert statement
3 participants
@FlyingZC @strongduanmu @menghaoranss