Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces with com.tisonkun.os:os-detector-maven-plugin to support building with Maven 4.0.0-beta-4 #32984

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Sep 24, 2024

Fixes #32568.

Changes proposed in this pull request:

sdk install java 22.0.2-graalce
sdk install maven 4.0.0-beta-4
git clone git@github.com:apache/shardingsphere.git
cd ./shardingsphere/
sdk use java 22.0.2-graalce
sdk use maven 4.0.0-beta-4
mvn clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true
  • Enjoy it,
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:47 min (Wall Clock)
[INFO] Finished at: 2024-09-24T20:59:40+08:00
[INFO] ------------------------------------------------------------------------

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian added this to the 5.5.1 milestone Sep 24, 2024
@taojintianxia taojintianxia merged commit 1334924 into apache:master Sep 24, 2024
141 checks passed
@linghengqian linghengqian deleted the maven-v400beta4 branch September 24, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the maven.version.range declaration in pom.xml to avoid contributors compiling with Maven 4.0.0-beta3?
2 participants