Added INSTR to Doris parsing support (#31508) #33289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- related to apache#31508 - includes test - `mvn spotless:apply -Pcheck` and `mvn test -Dtest=InternalDorisParserIT` - will update release notes in next commit - will check if MySQL supports INSTR in next commit - verified query in Doris
Small additional changes: - Also moved the java code to match the order in g4 more. - Added missing import as well.
danigiri
changed the title
Also added missing `// DORIS ADDED BEGIN|END` marker
strongduanmu
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of hacktoberfest, this is a POC for adding more parsing logic to Doris support. If this is successful, I will look at the other Doris SQL keywords in subsequent PRs. Continues to address #31508.
Note that
SELECT INSTR('foobar','bar')SELECT POSITION('bar' IN 'foobar')andSELECT LOCATE('bar','foobar')are the equivalentI understand that I cannot add the labels to the PR and maintainers have to do it.
Changes proposed in this pull request:
// DORIS ADDED BEGIN|ENDmarkers to code for both this change and Added BITXOR to Doris parsing support (#31508) #33258Next
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.mvn spotless:apply -Pcheckmvn test -Dtest=InternalDorisParserITin shardingsphere/parser/sql/dialect/dorisSELECT INSTR('foobar','bar')