Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes ConfigCenter api, reduce method. #3460

Merged
merged 1 commit into from
Nov 6, 2019
Merged

fixes ConfigCenter api, reduce method. #3460

merged 1 commit into from
Nov 6, 2019

Conversation

dongzl
Copy link
Contributor

@dongzl dongzl commented Nov 6, 2019

fixes ConfigCenter api, reduce method.

Changes proposed in this pull request:

  • remove getDirectly(), isExisted(), update(), persistEphemeral() methods.

wgy8283335
wgy8283335 reviewed Nov 6, 2019
View reviewed changes
Copy link
Contributor

@wgy8283335 wgy8283335 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Whether author should be removed should be discussed.

sunbufu
sunbufu approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@sunbufu sunbufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrymanu terrymanu added this to the 5.0.0 milestone Nov 6, 2019
@terrymanu terrymanu merged commit 34c0d0e into apache:orchestration-5.x Nov 6, 2019
@dongzl dongzl deleted the upstream/orchestration-5.x-config-api branch November 7, 2019 09:30
@terrymanu terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wgy8283335 wgy8283335 wgy8283335 left review comments

@terrymanu terrymanu terrymanu left review comments

@lovepoem lovepoem lovepoem left review comments

@sunbufu sunbufu sunbufu approved these changes

Assignees
No one assigned
Labels
mode: cluster type: enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dongzl @lovepoem @terrymanu @sunbufu @wgy8283335