#3657 Fix Admin have insecure permissions #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3658 +/- ##
============================================
- Coverage 62.43% 62.39% -0.04%
+ Complexity 5924 5921 -3
============================================
Files 903 903
Lines 24952 24956 +4
Branches 2283 2285 +2
============================================
- Hits 15578 15572 -6
- Misses 7928 7937 +9
- Partials 1446 1447 +1
Continue to review full report at Codecov.
|
| @@ -158,6 +161,11 @@ public ShenyuAdminResult modifyPassword(@PathVariable("id") | |||
| @Existed(provider = DashboardUserMapper.class, | |||
| message = "user is not found") final String id, | |||
| @Valid @RequestBody final DashboardUserDTO dashboardUserDTO) { | |||
| UserInfo userInfo = (UserInfo) SecurityUtils.getSubject().getPrincipal(); | |||
| if (Objects.isNull(userInfo) || !userInfo.getUserId().equals(id) | |||
There was a problem hiding this comment.
Objects.isNull(userInfo) maybe need to return another error message.
loongs-zhang
approved these changes
Jul 29, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.