-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[type:feat]Add dynamically scale admin module #5602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terminator111
changed the title
[type:feat]Add dynamically scale admin module sql and mapper
[type:feat]Add dynamically scale admin module
Aug 1, 2024
not delete icon |
done. |
misaya295
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty tests may not be submitted
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/entity/ScalePolicyDO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/test/java/org/apache/shenyu/admin/mapper/ScaleRuleMapperTest.java
Outdated
Show resolved
Hide resolved
misaya295
previously approved these changes
Aug 16, 2024
done. |
misaya295
requested changes
Sep 4, 2024
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java
Outdated
Show resolved
Hide resolved
shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ScalePolicyDTO.java
Outdated
Show resolved
Hide resolved
moremind
previously approved these changes
Sep 7, 2024
misaya295
previously approved these changes
Sep 7, 2024
@Terminator111 check ci pls |
Terminator111
dismissed stale reviews from misaya295 and moremind
via
September 7, 2024 09:08
d08bcee
misaya295
reviewed
Sep 11, 2024
misaya295
previously approved these changes
Sep 12, 2024
misaya295
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.