-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to protobuf #23
Conversation
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
Signed-off-by: Megrez Lu <lujiajing1126@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good for now. We should improve the codes to pass the CI check. And I recommend leveraging buf
to manage proto files.
api/proto/Makefile
Outdated
generate-go: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we leverage https://github.com/bufbuild/buf to check proto files and generate stubs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added buf.yaml
and buf.gen.yaml
to leverage buf
.
I exclude two rules, i.e. RPC_REQUEST_STANDARD_NAME
and RPC_RESPONSE_STANDARD_NAME
since they require *Request
and *Response
for request and response types. Do we need to impose these two rules?
@hanahmily I need some help from you to setup CI workflow. It seems there is restriction of Actions usage in this repo. Could you help setup the workflow? |
How about leave the workflow alone, let's merge it with some CI failures, I will submit another PR to fix them |
Sure. |
WARNING: Huge amount of change has been made in this PR.
Flatbuffers
fully removed. (I guess there is still some references ingo.sum
)Protbuf
introduced with adaptions made to fit with pb conventions.pkg
,banyand
directories.proto
files are not supported by Skywalking-eyes, manually added. Skip*.pb.go
and*.textproto
)buf
to lint and generateproto
s.Problem found in this PR
Relative timestamp in ChunkID
The timestamp contained in
chunkID
is not the same as thetimestamp
field in the entity since we are using a relative time shift. This shift will cause inaccurate Scan results.