-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin to support clickhouse jdbc #455
Conversation
feat:delete code
054e54e
to
119f6e8
Compare
Your local env should be JDK17, the class file could be jdk8 like most plugins. |
please check |
I am confused, clickhouse-jdbc plugin exists for 0.3.0 and 0.3.1. What does actually change in 0.3.2? Why do we have to write all rather than doing some compatible work on the original one? |
The author reconstructs in the new version, and the code structure changes, so compatibility is not recommended. Later versions of clickhouse-jdbc will remove the code from previous versions |
If so, please update the previous |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
clickhouse-0.3.2.x=org.apache.skywalking.apm.plugin.jdbc.clickhouse.v32.define.ConnectionInstrumentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plugin of 0.3.x uses clickhouse-0.3.x
. As 0.3.2 is an incompatible change, that keys should be updated to clickhouse-0.3.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clickhouse-0.3.x-plugin to clickhouse-0.3.1-plugin.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for keeping update.
Add an agent plugin to support <clickhouse-jdbc-0.3.2.*>
The new version of clickhouse-jdbc has major changes and needs to be re-compatible.
The author reconstructs in the new version, and the code structure changes, so compatibility is not recommended. Later versions of clickhouse-jdbc will remove the code from previous versions
Add a test case for the new plugin, refer to the doc
Add a component id in the component-libraries.yml
Add a logo in the UI repo
Update the
CHANGES
log.