Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swoole server on request param. #100

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Nov 8, 2023

@jmjoy jmjoy added this to the 0.8.0 milestone Nov 8, 2023
@jmjoy jmjoy self-assigned this Nov 8, 2023
wu-sheng
wu-sheng previously approved these changes Nov 8, 2023
@@ -21,7 +21,7 @@ members = [

[package]
name = "skywalking-php"
version = "0.7.0"
version = "0.8.0-dev"
authors = ["Apache Software Foundation", "jmjoy <jmjoy@apache.org>", "Yanlong He <heyanlong@apache.org>"]
description = "Apache SkyWalking PHP Agent."
edition = "2021"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to start a new version development.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 8, 2023

Please fix CI.

@jmjoy
Copy link
Member Author

jmjoy commented Nov 8, 2023

Please fix CI.

The vagrant of Mac in CI is crash, I will retry it later.

wu-sheng
wu-sheng previously approved these changes Nov 9, 2023
@wu-sheng wu-sheng added the enhancement New feature or request label Nov 9, 2023
@wu-sheng wu-sheng merged commit 981dad9 into apache:master Nov 9, 2023
28 checks passed
@jmjoy jmjoy deleted the swoole-fix branch November 9, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] PHP agent don't have any endpoint info
2 participants