Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin] add aiohttp plugin #101

Merged
merged 6 commits into from
Dec 13, 2020
Merged

[Plugin] add aiohttp plugin #101

merged 6 commits into from
Dec 13, 2020

Conversation

tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Dec 12, 2020 •
edited
Loading

Continuing #100

  • Add a test case for the new plugin
  • Add a component id in the main repo
  • Add a logo in the UI repo
  • Rebuild the requirements.txt by running tools/env/build_requirements_(linux|windows).sh

@kezhenxu94
Copy link
Member

Hi @tom-pytel , I've added the test case for you, some of the fields (peer) are not aligned correctly, please adjust according to the expected data, thanks, I'll review the other plugins about the peer field that we mentioned in #100

@tom-pytel
Copy link
Contributor Author

Hi @tom-pytel , I've added the test case for you, some of the fields (peer) are not aligned correctly, please adjust according to the expected data, thanks, I'll review the other plugins about the peer field that we mentioned in #100

Not just peer, might be possibility of pwd showing up in url field too maybe.

@kezhenxu94 kezhenxu94 added the plugin Plugin label Dec 13, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Dec 13, 2020
@kezhenxu94 kezhenxu94 mentioned this pull request Dec 13, 2020
Merged
kezhenxu94
kezhenxu94 previously approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last step is to add the component id to the main repo

https://github.com/apache/skywalking/blob/84af1d23834ef3c6ed17980c5270fc42d6e7d5b3/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L479

which may only cost 10 seconds for you but I'd appreciate it and the credits should belong to you

@kezhenxu94 kezhenxu94 changed the title aiohttp plugin [Plugin] add aiohttp plugin Dec 13, 2020
@kezhenxu94 kezhenxu94 merged commit 65c6e4a into apache:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
plugin Plugin
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-pytel @kezhenxu94