[plugin] add falcon plugin #146
Conversation
probeyang
commented
Aug 6, 2021
probeyang
commented
add tornado5+ and tornado6+ support
add tornado5.1.1 test case and format tornado plugin code
add the plugin of falcon
format code
expected data change, falcon component code change to 7012.
|
New sw_tornado5.py in this PR is identical to the old sw_tornado.py, so why split it into two different plugins? Also it is based on an older version in master which is missing a peer address fix and the recent exclude by http method functionality. |
| @@ -43,6 +43,7 @@ class Component(Enum): | |||
| Pyramid = 7009 | |||
| Psycopg = 7010 | |||
| Celery = 7011 | |||
| Falcon = 7012 | |||
There was a problem hiding this comment.
@probeyang can you please add a component id in the main repo and a logo in the UI repo? https://github.com/apache/skywalking/blob/bca62f63fa0c57bf3bb5d8ebde9d6969b55b8429/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L527-L528
|
I am good with this (pending last @kezhenxu94 issue main repo updates of course). |
Not quite good yet, need to update for new Tag change. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
skywalking/plugins/sw_falcon.py
Outdated
| req = request.Request(env, RequestOptions()) | ||
| span.op = str(req.url).split("?")[0] | ||
| span.peer = "%s:%s" % (req.remote_addr, req.port) | ||
| span.tag(Tag(key=tags.HttpMethod, val=req.method)) |
There was a problem hiding this comment.
These should be changed to:
span.tag(TagHttpMethod(req.method))
span.tag(TagHttpURL(str(req.url)))
if req.params:
span.tag(TagHttpParams(params_tostring(req.params)[0:]))And the import at the top to:
from skywalking.trace.tags import TagHttpMethod, TagHttpURL, TagHttpParams
There was a problem hiding this comment.
Also, status tag not being set?
There was a problem hiding this comment.
Also, status tag not being set?
@probeyang can you add the status tag?
There was a problem hiding this comment.
thanks a lot, i found my code is older than apache/skywalking-python, i upgrade it.
There was a problem hiding this comment.
ok, i will set status argument
Span Tag Use TagHttpMethod, TagHttpURL, TagHttpParams
ok , i will update it. |
update changelog and plugins.md.
delete unused tags
Add New Argument: TagHttpStatusCode Span Tag
|
You need to revert the submodule update |
ok |
revert protocol
revert protocol
Update expected.data.yml
Add falcon plugin (apache#146)
