Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support log reporter safe mode #200

Merged
merged 7 commits into from
Mar 30, 2022

Conversation

Superskyyy
Copy link
Member

@Superskyyy Superskyyy commented Mar 30, 2022

  • Safe mode involves an additional config that turns on the filtering for HTTP basic auth in log reporter and trace logs (it was originally on by default, now off by default due to REGEX performance in long log records)
  • Refactored config.py to remove excess expressions mostly like below -
    Please correct if I'm wrong, but these and's don't seem necessary
flask_collect_http_params = True if os.getenv('SW_FLASK_COLLECT_HTTP_PARAMS') and \
                                    os.getenv('SW_FLASK_COLLECT_HTTP_PARAMS') == 'True' else False

to

flask_collect_http_params = os.getenv('SW_FLASK_COLLECT_HTTP_PARAMS') == 'True'
  • Refactored config.py type hints to modern style (Py3.6+ style)
  • Add a e2e entry to verify the log reporter safe mode.
  • Attempt to fix the main branch failure situation (I guess it's a correct solution).

Signed-off-by: Superskyyy superskyyy@outlook.com

Signed-off-by: Superskyyy <superskyyy@outlook.com>
Signed-off-by: Superskyyy <superskyyy@outlook.com>
Signed-off-by: Superskyyy <superskyyy@outlook.com>
Signed-off-by: Superskyyy <superskyyy@outlook.com>
Signed-off-by: Superskyyy <superskyyy@outlook.com>
Signed-off-by: Superskyyy <superskyyy@outlook.com>
skywalking/config.py Outdated Show resolved Hide resolved
kezhenxu94
kezhenxu94 previously approved these changes Mar 30, 2022
Signed-off-by: Superskyyy <superskyyy@outlook.com>
@Superskyyy Superskyyy merged commit d1381c5 into apache:master Mar 30, 2022
@wu-sheng wu-sheng added this to the 1.0.0 milestone Mar 30, 2022
@wu-sheng wu-sheng added the test test label Mar 30, 2022
@Superskyyy Superskyyy deleted the perf-make-safety-optional branch April 15, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants