Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead MIT gpg site and fix release command #294

Merged
merged 4 commits into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,6 @@ clean:

.PHONY: release
release: clean lint license
-tar -zcvf skywalking-python-src-$(VERSION).tgz --exclude .venv *
gpg --batch --yes --armor --detach-sig skywalking-python-src-$(VERSION).tgz
shasum -a 512 skywalking-python-src-$(VERSION).tgz > skywalking-python-src-$(VERSION).tgz.sha512
tar -zcvf skywalking-python-src-$VERSION.tgz --exclude .venv *
gpg --batch --yes --armor --detach-sig skywalking-python-src-$VERSION.tgz
shasum -a 512 skywalking-python-src-$VERSION.tgz > skywalking-python-src-$VERSION.tgz.sha512
9 changes: 3 additions & 6 deletions docs/en/contribution/How-to-release.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@ This documentation guides the release manager to release the SkyWalking Python i
1. Close (if finished, or move to next milestone otherwise) all issues in the current milestone from [skywalking-python](https://github.com/apache/skywalking-python/milestones) and [skywalking](https://github.com/apache/skywalking/milestones), create a new milestone if needed.
2. Update CHANGELOG.md and `version` in `pyproject.toml`.


## Add your GPG public key to Apache svn

1. Upload your GPG public key to a public GPG site, such as [MIT's site](http://pgp.mit.edu:11371/).
## Add your GPG public key to Apache SVN

1. Log in [id.apache.org](https://id.apache.org/) and submit your key fingerprint.

1. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**. You can ask a PMC member for help. **DO NOT override the existed `KEYS` file content, only append your key at the end of the file.**
Superskyyy marked this conversation as resolved.
Show resolved Hide resolved
2. Add your GPG public key into [SkyWalking GPG KEYS](https://dist.apache.org/repos/dist/release/skywalking/KEYS) file, **you can do this only if you are a PMC member**. You can ask a PMC member for help. **DO NOT override the existed `KEYS` file content, only append your key at the end of the file.**


## Build and sign the source code package
Expand All @@ -29,7 +26,7 @@ git push --tags
make clean && make release
```

## Upload to Apache svn
## Upload to Apache SVN

```bash
svn co https://dist.apache.org/repos/dist/dev/skywalking/python release/skywalking/python
Expand Down