Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flask plugin #31

Merged
merged 29 commits into from
Jul 2, 2020
Merged

Flask plugin #31

merged 29 commits into from
Jul 2, 2020

Conversation

alonelaval
Copy link
Member

@alonelaval alonelaval commented Jul 2, 2020 •
edited by kezhenxu94
Loading

@kezhenxu94 kezhenxu94 added the plugin Plugin label Jul 2, 2020
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Jul 2, 2020
kezhenxu94
kezhenxu94 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit d4e663a into master Jul 2, 2020
@kezhenxu94 kezhenxu94 deleted the flask-plugin branch July 2, 2020 15:00
@kezhenxu94
Copy link
Member

@alonelaval can you please add a logo in the UI repo, refer to apache/skywalking-rocketbot-ui#303
and add a component in the main repo: https://github.com/apache/skywalking/blob/31f42343f6f38ca4838a02866be3bdde7fc3d12a/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L395

@alonelaval
Copy link
Member Author

ok

This was referenced Jul 4, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
plugin Plugin
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

[PythonAgent] Support Flask framework
2 participants
@alonelaval @kezhenxu94