Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PyMsql Plugin #35

Merged
merged 14 commits into from
Jul 15, 2020
Merged

Add PyMsql Plugin #35

merged 14 commits into from
Jul 15, 2020

Conversation

alonelaval
Copy link
Member

No description provided.

@kezhenxu94 kezhenxu94 added feature New feature plugin Plugin labels Jul 13, 2020
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Jul 13, 2020
kezhenxu94
kezhenxu94 reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit and one suggestion (don't need to be addressed in this PR)

tests/plugin/sw_pymysql/services/provider.py Show resolved Hide resolved
skywalking/plugins/sw_pymysql/__init__.py Show resolved Hide resolved
@kezhenxu94 kezhenxu94 changed the title add PyMsql Plugin Add PyMsql Plugin Jul 15, 2020
kezhenxu94
kezhenxu94 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in codes and locally test, thanks @alonelaval very much, please remember to update the component in the main repo, we may need mapping this time

@kezhenxu94 kezhenxu94 merged commit c30b10b into apache:master Jul 15, 2020
@alonelaval
Copy link
Member Author

Looks good to me in codes and locally test, thanks @alonelaval very much, please remember to update the component in the main repo, we may need mapping this time

good vpn...LOL

@alonelaval alonelaval mentioned this pull request Jul 19, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
feature New feature plugin Plugin
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alonelaval @kezhenxu94