Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin] check version of packages when install plugins #63

Merged
merged 5 commits into from
Aug 13, 2020
Merged

[Plugin] check version of packages when install plugins #63

merged 5 commits into from
Aug 13, 2020

Conversation

Humbertzhang
Copy link
Member

No description provided.

@kezhenxu94 kezhenxu94 added plugin Plugin enhancement New feature or request labels Aug 11, 2020
@kezhenxu94 kezhenxu94 added this to the 0.3.0 milestone Aug 11, 2020
kezhenxu94
kezhenxu94 reviewed Aug 11, 2020
View reviewed changes
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
kezhenxu94
kezhenxu94 reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new config to the plugin development doc, and indicates what is the logical operation between the rules array, AND? OR?

version_rule = {
     "name": "django",
     "rules": [">=2.0"]
 }

skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
skywalking/plugins/__init__.py Outdated Show resolved Hide resolved
kezhenxu94
kezhenxu94 approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit 518002f into apache:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
core enhancement New feature or request plugin Plugin
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Humbertzhang @kezhenxu94