Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elasticsearch plugin #64

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Add elasticsearch plugin #64

merged 3 commits into from
Aug 12, 2020

Conversation

alonelaval
Copy link
Member

@alonelaval alonelaval commented Aug 12, 2020 •
edited by kezhenxu94
Loading

  • Add a test case for the new plugin
  • Add a component id in the main repo
  • Add a logo in the UI repo
  • Add the library/module that this plugin instruments into the setup.py (extras_require/test), such as pymysql, flask, django, etc.
  • Rebuild the requirements.txt by running tools/env/build_requirements_(linux|windows).sh

resolve apache/skywalking#5295

@alonelaval alonelaval requested a review from kezhenxu94 August 12, 2020 08:17
@kezhenxu94 kezhenxu94 added plugin Plugin feature New feature labels Aug 12, 2020
@kezhenxu94 kezhenxu94 added this to the 0.3.0 milestone Aug 12, 2020
kezhenxu94
kezhenxu94 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kezhenxu94 kezhenxu94 merged commit 0308fbf into master Aug 12, 2020
@alonelaval alonelaval deleted the es branch August 23, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
feature New feature plugin Plugin
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Support elasticsearch in python agent
2 participants
@alonelaval @kezhenxu94