Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden e2e test by adding healthCheck #10

Merged
merged 10 commits into from
Jan 22, 2022

Conversation

tisonkun
Copy link
Member

Signed-off-by: tison wander4096@gmail.com

... according to #9 (comment).

This is a draft PR and I submit it for running tests. I'll set it as ready for review after validation.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022

Codecov Report

Merging #10 (a647136) into master (f4743a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files           9        9           
  Lines         283      283           
=======================================
  Hits          241      241           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4743a9...a647136. Read the comment docs.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review January 21, 2022 13:06
@tisonkun
Copy link
Member Author

@Shikugawa @wu-sheng I think the tests is somehow stable and you can review that whether the change is valid.

.github/workflows/e2e.yml Outdated Show resolved Hide resolved
@wu-sheng wu-sheng added this to the 0.1.0 milestone Jan 21, 2022
@wu-sheng wu-sheng requested a review from kezhenxu94 January 21, 2022 13:08
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Copy link
Member

@Shikugawa Shikugawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. A nit comment.

tests/e2e/run_e2e.py Outdated Show resolved Hide resolved
@Shikugawa
Copy link
Member

This PR is very helpful and worth doing to implement other agent implementations using the same mechanism on regression tests, such as cpp2sky.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Member Author

@Shikugawa @wu-sheng this PR is ready for review.

@wu-sheng wu-sheng requested a review from Shikugawa January 22, 2022 12:06
Copy link
Member

@Shikugawa Shikugawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Shikugawa Shikugawa merged commit 39232e5 into apache:master Jan 22, 2022
@tisonkun tisonkun deleted the e2e-liveness-probe branch January 22, 2022 16:59
@tisonkun
Copy link
Member Author

@Shikugawa thanks for your review! You may clean up the squash commit message the next time. I think most of them are meaningless. Or you can ask me to do the squash :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants