-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harden e2e test by adding healthCheck #10
Conversation
Signed-off-by: tison <wander4096@gmail.com>
0cae865
to
8ccac6d
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 9 9
Lines 283 283
=======================================
Hits 241 241
Misses 42 42 Continue to review full report at Codecov.
|
@Shikugawa @wu-sheng I think the tests is somehow stable and you can review that whether the change is valid. |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. A nit comment.
This PR is very helpful and worth doing to implement other agent implementations using the same mechanism on regression tests, such as cpp2sky. |
Signed-off-by: tison <wander4096@gmail.com>
416719c
to
662f499
Compare
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@Shikugawa @wu-sheng this PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Shikugawa thanks for your review! You may clean up the squash commit message the next time. I think most of them are meaningless. Or you can ask me to do the squash :P |
Signed-off-by: tison wander4096@gmail.com
... according to #9 (comment).
This is a draft PR and I submit it for running tests. I'll set it as ready for review after validation.