Chore(tonic-build): set tonic-build.build_server(false), do not build Server code. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your codes are not formated correctly, please fix it. |
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 9 9
Lines 298 298
=======================================
Hits 259 259
Misses 39 39 Continue to review full report at Codecov.
|
CherishCai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue apache/skywalking#9271
the
trace_segment_report_service_server::TraceSegmentReportServiceServerbuilt by tonic-build is redundant now, and adding.build_server(false)can reduce the generation of this code.