-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename crate name skywalking_rust to skywalking? #23
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
Coverage 86.91% 86.91%
=======================================
Files 9 9
Lines 298 298
=======================================
Hits 259 259
Misses 39 39
Continue to review full report at Codecov.
|
It works for me, but we have to release 0.2.0 to make this works. |
We should keep this hold when we are going to release 0.2.0 right away. Otherwise, the readme doc would look like wrong for the end-users. Right? |
use skywalking::context::trace_context::TracingContext; | ||
use skywalking::reporter::grpc::Reporter; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compiling doc in the readme is still skywalking-rust, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiling doc is means the doc generated by cargo doc
? With 0.2.0 released, the skywalking
will be a new crate and the name is skywalking
in docs.rs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't mean this is wrong. I mean https://github.com/apache/skywalking-rust#how-to-compile doesn't match here.
OK, but I think the crate name |
In Apache, we have to release it officially(a new tag approved by the PMC), then I could publish it to the cargo. Do you think it is a good time to release 0.2.0? And we move capture/continuous to 0.3.0? |
I think it is OK, or use alpha version like 0.2.0-alpha.1 ? |
I think it is fine if 0.2.0 APIs would be changed in 0.3.0. We usually just make sure 1.0 as a stable version. |
Yes, so we can use 0.2.0. |
@jmjoy Are you in the slack or QQ group? Or could you add me wechat through @heyanlong? (I think you two know each other?) I may need your help to release 0.2.0, as you are not a committer yet. This library was released by @Shikugawa , who is busy in his daily work. |
I'm not in QQ group, I just have the QQ of heyanlong, maybe you can give me the QQ gorup number? |
I just added you through QQ on your profile page. |
The suffix
_rust
is not necessary, and using the crate nameskywalking
can prevent fraudulent use by third parties.