Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move e2e to workspace. #27

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Move e2e to workspace. #27

merged 2 commits into from
Jul 11, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 11, 2022

  1. Cargo.lock is not needed for e2e test (can't assume which dependency version the user is using).
  2. Integrate e2e into workspace for a better IDE experience.

@codecov-commenter
Copy link

Codecov Report

Merging #27 (6a87d24) into master (699247d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   75.29%   75.29%           
=======================================
  Files          10       10           
  Lines         344      344           
=======================================
  Hits          259      259           
  Misses         85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699247d...6a87d24. Read the comment docs.

wu-sheng
wu-sheng reviewed Jul 11, 2022
View reviewed changes
e2e/Cargo.toml Outdated
@@ -21,6 +21,7 @@ version = "0.2.0"
authors = ["Shikugawa <Shikugawa@gmail.com>"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add your name in here, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as in the root.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Apache SkyWalking Developers (dev@skywalking.apache.org)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want the official author, then Apache Software Foundation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the email of Apache Software Foundation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be a website? There is no official mail box.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or left the email empty.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the website is acceptable, let's use https://skywalking.apache.org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website is already defined in homepage of Cargo.toml, the authors only accept an email.

@wu-sheng wu-sheng added this to the 0.3.0 milestone Jul 11, 2022
@wu-sheng wu-sheng merged commit 0c43b32 into apache:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jmjoy @codecov-commenter @wu-sheng