Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to 0.3.0. #30

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Bump to 0.3.0. #30

merged 1 commit into from
Jul 19, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 19, 2022

No description provided.

jmjoy
jmjoy commented Jul 19, 2022
View reviewed changes
e2e/Cargo.toml
@@ -17,7 +17,7 @@
#
[package]
name = "e2e"
version = "0.2.0"
version = "0.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 0.0.0 because the version of e2e isn't important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0.0 means using the latest version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mean there is no version, since it doesn't have to be published to crates.io, it doesn't matter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean does this guarantee it would use the latest build version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line insures to use the latest version.

skywalking-rust/e2e/Cargo.toml

Line 27 in d14a0bd

skywalking = { path = ".." }

@jmjoy jmjoy marked this pull request as ready for review July 19, 2022 03:24
@wu-sheng wu-sheng added this to the 0.3.0 milestone Jul 19, 2022
@jmjoy
Copy link
Member Author

jmjoy commented Jul 19, 2022

There is a question, does e2e source code have to be included to .crate? Because e2e is integrated into worksapce, there is no e2e source code when run cargo package.

@wu-sheng
Copy link
Member

Once users are not being affected, then it is not an issue. You could choose a way which is more convenience for developers.

@jmjoy
Copy link
Member Author

jmjoy commented Jul 19, 2022

Once users are not being affected, then it is not an issue. You could choose a way which is more convenience for developers.

Then it's fine.

@wu-sheng wu-sheng merged commit 2d61651 into apache:master Jul 19, 2022
@jmjoy jmjoy deleted the bump branch July 19, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jmjoy @wu-sheng