Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move skywalking_proto mod to single files. #33

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Jul 21, 2022

Move skywalking_proto mod to single files, and add some methods to SpanObject.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #33 (b6d0720) into master (e8aba5a) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   39.01%   38.88%   -0.13%     
==========================================
  Files          12       13       +1     
  Lines         305      306       +1     
==========================================
  Hits          119      119              
- Misses        186      187       +1     
Impacted Files Coverage Δ
src/context/span.rs 0.00% <0.00%> (ø)
src/skywalking_proto/v3/mod.rs 0.00% <0.00%> (ø)

@jmjoy jmjoy marked this pull request as ready for review July 21, 2022 02:14
@wu-sheng wu-sheng added this to the 0.4.0 milestone Jul 21, 2022
@wu-sheng wu-sheng added the enhancement New feature or request label Jul 21, 2022
@wu-sheng wu-sheng merged commit 3d12768 into apache:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants