Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add management support. #48

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Add management support. #48

merged 4 commits into from
Sep 15, 2022

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Sep 14, 2022

  1. Add report instance properties support.
  2. Add keep alive support.
  3. Replace function params ToString to Into<String> for better semantics.
  4. Upgrade min rust version requirement.

@jmjoy jmjoy added the enhancement New feature or request label Sep 14, 2022
@jmjoy jmjoy added this to the 0.5.0 milestone Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #48 (41d7af1) into master (10aa902) will decrease coverage by 0.72%.
The diff coverage is 7.31%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   22.12%   21.40%   -0.73%     
==========================================
  Files          18       20       +2     
  Lines         592      612      +20     
==========================================
  Hits          131      131              
- Misses        461      481      +20     
Impacted Files Coverage Δ
src/logging/logger.rs 0.00% <0.00%> (ø)
src/logging/record.rs 0.00% <0.00%> (ø)
src/management/instance.rs 0.00% <0.00%> (ø)
src/metrics/meter.rs 0.00% <0.00%> (ø)
src/metrics/metricer.rs 0.00% <0.00%> (ø)
src/reporter/grpc.rs 0.00% <0.00%> (ø)
src/reporter/mod.rs 0.00% <ø> (ø)
src/reporter/print.rs 36.84% <ø> (ø)
src/skywalking_proto/v3/mod.rs 0.00% <ø> (ø)
src/trace/span.rs 0.00% <ø> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmjoy jmjoy marked this pull request as ready for review September 15, 2022 02:22
@jmjoy jmjoy requested a review from wu-sheng September 15, 2022 02:22
wu-sheng
wu-sheng previously approved these changes Sep 15, 2022
@wu-sheng
Copy link
Member

Do the properties of instance support customization? Such as using a JSON to inject some flags to instance properties?

@wu-sheng wu-sheng merged commit 7d344de into apache:master Sep 15, 2022
@jmjoy jmjoy deleted the manager branch September 15, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants