Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit of skywalking-rust with full-tracing features. #5

Merged
merged 6 commits into from
Dec 19, 2021

Conversation

Shikugawa
Copy link
Member

No description provided.

@Shikugawa
Copy link
Member Author

@wu-sheng PTAL

@wu-sheng
Copy link
Member

Whoo, you have finished this.

@wu-sheng wu-sheng added this to the 0.1.0 milestone Dec 18, 2021
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@wu-sheng
Copy link
Member

BTW, we should add our own Attributes to support adding a span in the current context, then use attribute to add tag or use explicit APIs to add tags/logs

WDYT?

README.md Outdated Show resolved Hide resolved
@Shikugawa
Copy link
Member Author

BTW, we should add our own Attributes to support adding a span in the current context, then use attribute to add tag or use explicit APIs to add tags/logs

How is Attributes? I expect it works to register default tags/logs settings to span, is it correct?

@wu-sheng
Copy link
Member

We could start with adding a local tag? And tag/log and other types of span.

@wu-sheng
Copy link
Member

This is a suggestion, we could do that in another PR later.
Just fixing the CI task name and doc(APIs) should be good.

@Shikugawa
Copy link
Member Author

We could start with adding a local tag? And tag/log and other types of span.

Ah ok. What you said is like this?

@wu-sheng
Copy link
Member

Oh, I mean this https://doc.rust-lang.org/reference/procedural-macros.html. Something like

#[span(xxx)]
pub fn one_function(....) -> .... {
    ....
}

@Shikugawa
Copy link
Member Author

Oh, I mean this https://doc.rust-lang.org/reference/procedural-macros.html. Something like

#[span(xxx)]
pub fn one_function(....) -> .... {
    ....
}

Got it. SG and worth doing to add this feature.

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@wu-sheng
Copy link
Member

CI fails.

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@wu-sheng
Copy link
Member

You seems forgot to add e2e into GHA control file.

@Shikugawa
Copy link
Member Author

You seems forgot to add e2e into GHA control file.

I'm debugging e2e CI in my local repository. I will send another PR if it is ready.

Signed-off-by: Shikugawa <Shikugawa@gmail.com>
@wu-sheng wu-sheng merged commit e4ce370 into apache:master Dec 19, 2021
@Shikugawa Shikugawa deleted the init branch December 19, 2021 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants